lib/tool-views/: group the tool-view modules (machine-tool-view misnomer fixed) #124

Merged

chad merged 1 commit from glen/refactor-lib-tool-views into main

2026-10-17 23:47:57 -04:00

glen commented

2026-10-17 23:39:38 -04:00

Collaborator

The last mechanical item from the maintainability review (#123) — a pure move-and-rename, zero behavior change.

What: the eight tool-view normalizer modules scattered at lib/ root now live under lib/tool-views/, and the machine-tool-view misnomer is fixed — machines were deleted by 0037 phase 5; the module is the generic inspect/exec/transition result normalizer, now tool-views/inspect.ts (with a two-line rename note). Mapping: machine-tool-view→inspect, info-tool-view→info, file-tool-view→file, list-tool-view→list, bash-view→bash, web-tool-view→web, tool-fields→fields, tool-groups→groups. All via git mv (history follows; two files byte-identical, six changed only in import paths + prose comment names). 10 importer files updated, 5 test files renamed (import paths only), one AGENTS.md line.

Deliberately untouched: TransitionCard, transitionOf, and the harness-session-view transition arm — they render historical harness_events rows, so their fate belongs to 0048's option A/B decision, not this pass.

Verification: fresh-eyes review child confirmed all eight moves clean (byte-diffs vs old paths), zero stale references repo-wide, test files import-only, gates exact: tsc clean, eslint 0 new warnings, 777 passed / 13 skipped. Verdict: ship.

Implemented by pi, reviewed by a fresh child thread, verified in-thread.

The last mechanical item from the maintainability review (#123) — a pure move-and-rename, zero behavior change. **What:** the eight tool-view normalizer modules scattered at `lib/` root now live under `lib/tool-views/`, and the `machine-tool-view` misnomer is fixed — machines were deleted by 0037 phase 5; the module is the generic inspect/exec/transition result normalizer, now `tool-views/inspect.ts` (with a two-line rename note). Mapping: `machine-tool-view→inspect`, `info-tool-view→info`, `file-tool-view→file`, `list-tool-view→list`, `bash-view→bash`, `web-tool-view→web`, `tool-fields→fields`, `tool-groups→groups`. All via `git mv` (history follows; two files byte-identical, six changed only in import paths + prose comment names). 10 importer files updated, 5 test files renamed (import paths only), one AGENTS.md line. **Deliberately untouched:** `TransitionCard`, `transitionOf`, and the `harness-session-view` transition arm — they render historical `harness_events` rows, so their fate belongs to 0048's option A/B decision, not this pass. **Verification:** fresh-eyes review child confirmed all eight moves clean (byte-diffs vs old paths), zero stale references repo-wide, test files import-only, gates exact: tsc clean, eslint 0 new warnings, **777 passed / 13 skipped**. Verdict: ship. Implemented by pi, reviewed by a fresh child thread, verified in-thread.

glen added 1 commit

2026-10-17 23:39:38 -04:00

refactor(lib): group the tool-view modules under lib/tool-views/ (machine-tool-view misnomer fixed)

deploy / checks (pull_request) Successful in 40s

Details

deploy / deploy (pull_request) Has been skipped

Details

a8318a00d7

Mechanical move-and-rename, zero behavior change. The tool-view
normaliser modules scattered at lib/ root now live under lib/tool-views/,
and the machine-tool-view misnomer is fixed: machines were deleted by
0037 phase 5, so the generic inspect/exec/transition result normaliser
is now named for what it does.

Mapping (git mv, history follows):
  lib/machine-tool-view.ts -> lib/tool-views/inspect.ts
  lib/info-tool-view.ts    -> lib/tool-views/info.ts
  lib/file-tool-view.ts    -> lib/tool-views/file.ts
  lib/list-tool-view.ts    -> lib/tool-views/list.ts
  lib/bash-view.ts         -> lib/tool-views/bash.ts
  lib/web-tool-view.ts     -> lib/tool-views/web.ts
  lib/tool-fields.ts       -> lib/tool-views/fields.ts
  lib/tool-groups.ts       -> lib/tool-views/groups.ts

Every importer path rewritten (components/, tests/), the moved files'
own relative imports updated (file.ts reaches ../harness-limits, the
cross-imports become ./fields ./inspect ./bash), tests renamed to match
(tool-views-*.test.ts), AGENTS.md's one path reference updated, and a
rename note added at the top of inspect.ts.

chad merged commit 48bd6e75fc into main

2026-10-17 23:47:57 -04:00

chad referenced this pull request from a commit

2026-10-17 23:47:58 -04:00

Merge pull request 'lib/tool-views/: group the tool-view modules (machine-tool-view misnomer fixed)' (#124) from glen/refactor-lib-tool-views into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

chad/sweatshop-legacy!124

No description provided.

Rows
Columns